fix(reactivity): when setting a property the shallowReactive object s… #12688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hould not unwrap refs and the reactive object should retain readonly proxy
|
Can you add relevant test cases for the bugs you are fixing? |
yyx990803
added a commit
that referenced
this pull request
Jul 22, 2022
|
Thanks for the PR - as I was writing the test case for it, I discovered some edge cases that wasn't even working correctly in Vue 3:
These are fixed for Vue 3 in vuejs/core@a95554d This PR also has subtle issues that are better explained via test cases - I also took the opportunity to align the behavior with Vue 3, see 2af751b. |
|
Sorry, I just saw it. Is the property of the reactive object always a ref once it is assigned to a ref, just hidden by the internal unwrap ref behavior? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hould not unwrap refs and the reactive object should retain readonly proxy
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: